yashmayya commented on PR #17058: URL: https://github.com/apache/pinot/pull/17058#issuecomment-3444516399
> Backward incompatible is fine. We need to find a way to make the tests pass Yeah I've refactored the compat verifier test framework to support taking in multiple expected column types (older will be `DOUBLE`, newer will be `LONG`) and ignoring column name mismatch (we don't care about `min(longCol)` vs `minlong(longCol)` for instance, and we've made similar changes in the past like `LONG` -> `BIGINT` for casts). Otherwise these tests would keep failing when run versus older versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
