Jackie-Jiang commented on code in PR #17058:
URL: https://github.com/apache/pinot/pull/17058#discussion_r2460713144
##########
pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/AggregateFunctionRewriteOptimizer.java:
##########
@@ -27,9 +27,17 @@
import org.apache.pinot.spi.data.FieldSpec;
import org.apache.pinot.spi.data.Schema;
-/**
- * Rewrites aggregate functions to type-specific versions in order to support
polymorphic functions.
- */
+///
Review Comment:
(nit) Remove redundant leading/trailing empty line javadoc
##########
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/AggregateMetricsRule.java:
##########
@@ -67,8 +67,10 @@ private boolean shouldAggregate(InputManager inputManager) {
continue;
}
FunctionContext funcCtx = selectExpr.getFunction();
- if (selectExpr.getType() != ExpressionContext.Type.FUNCTION ||
!funcCtx.getFunctionName()
- .equalsIgnoreCase("SUM") ||
hasNonMetricArguments(funcCtx.getArguments(), metricNames)) {
+ if (selectExpr.getType() != ExpressionContext.Type.FUNCTION || (
+ !funcCtx.getFunctionName().equalsIgnoreCase("SUM") &&
!funcCtx.getFunctionName().equalsIgnoreCase("SUMINT")
Review Comment:
@sajjad-moradi Can you help take a look at this part? Should we also include
`SUM_PRECISION` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
