kmozaid commented on PR #16836: URL: https://github.com/apache/pinot/pull/16836#issuecomment-3404192658
> Very nice! > > Since we need to handle aggregated values the same way as single-valued input, another approach would be to support MV in regular `Count`, `Sum`, `Avg`. Essentially add a SV/MV check in these functions so that they can handle MV columns. This way user can directly use the regular function on MV columns. IMO this way is more user friendly. Do you want to also try this approach out? You can open a separate PR and we can compare the 2 approaches Thanks for reviewing. Yes, we can do that but anyway, we need to have support for mv functions since they exists. Can I create another PR (once current PR is merged) for adding support in regular functions since I need to anyway add support more functions like distinctcounbitmap, distinctcounthll etc, would that work? Currently, I would prefer to get review comments resolved and get this PR merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
