kmozaid commented on PR #16836: URL: https://github.com/apache/pinot/pull/16836#issuecomment-3409166986
> `Avg` can be used to handle both SV and MV `AvgMVAggregationFunction' code will need to be moved into `AvgAggregationFunction`, including `aggregateGroupBySV` and `aggregateGroupByMV` functions code for handling normal query execution (without StarTree index), and that will make `AvgMVAggregationFunction` obsolete. Same will need to be done for other functions like SUM, COUNT etc, also StartTree index creation has special handling for count(*) on single value field, which will need to be changed. I strongly feel that, this kind of change warrant a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
