kmozaid commented on code in PR #16836:
URL: https://github.com/apache/pinot/pull/16836#discussion_r2358318084


##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumMVAggregationFunction.java:
##########
@@ -95,6 +118,19 @@ public void aggregateGroupBySV(int length, int[] 
groupKeyArray, GroupByResultHol
   public void aggregateGroupByMV(int length, int[][] groupKeysArray, 
GroupByResultHolder groupByResultHolder,
       Map<ExpressionContext, BlockValSet> blockValSetMap) {
     BlockValSet blockValSet = blockValSetMap.get(_expression);
+
+    if (blockValSet.isSingleValue()) {

Review Comment:
   This code block should be removed as startree index won't be in effect when 
group by multi-value column, and should be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to