gortiz commented on code in PR #16899:
URL: https://github.com/apache/pinot/pull/16899#discussion_r2438992399
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -96,8 +98,13 @@ public void send(MseBlock.Data data) {
@Override
public void send(MseBlock.Eos block, List<DataBuffer> serializedStats) {
sendInternal(block, serializedStats);
- LOGGER.debug("Completing mailbox: {}", _id);
- _contentObserver.onCompleted();
+ if (_closeAttempted) {
Review Comment:
We verify that the check is performed inside `sendInternal` because we want
to apply the same check to data blocks. Here we need to check again because we
want to change the state in case the block was actually sent.
I can change the code a little bit to make it cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
