gortiz commented on PR #16899: URL: https://github.com/apache/pinot/pull/16899#issuecomment-3365940400
> If the problem is in QueryRunner, there is a much easier fix The problem _is_ in QueryRunner. It can be fixed there for sure with a one or two-line change, but that is not the point. We had that bug for a while, and we didn't detect it. By making sending mailboxes closable, we protect the system for the future. Given that it is a closable resource, the static tools (including IDEs) will suggest closing it. And if we close it without properly completing or canceling the mailbox, it will cancel the mailbox (preventing leaks) and also log a message (helping us to fix the issue). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
