gortiz commented on PR #16899: URL: https://github.com/apache/pinot/pull/16899#issuecomment-3366064658
BTW, an even better design would remove the `SendingMailbox.complete` method given that a mailbox is closed if a MseBlock.Eos is received. Therefore, we could reformat our code to call complete in that case automatically. That is what I'm doing in https://github.com/apache/pinot/pull/16915 Both that PR and this PR are orthogonal and make the API less error-prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
