Jackie-Jiang commented on code in PR #16983:
URL: https://github.com/apache/pinot/pull/16983#discussion_r2417755468
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java:
##########
@@ -99,15 +99,23 @@ protected AggregationResultsBlock getNextBlock() {
break;
case MIN:
case MINMV:
- result = getMinValue(dataSource);
+ result = getMinValueNumeric(dataSource);
+ break;
+ case MINSTRING:
+ result = dataSource.getDictionary() != null ?
dataSource.getDictionary().getMinVal()
+ : dataSource.getDataSourceMetadata().getMinValue();
Review Comment:
IIRC, this might not always be correct. When we write metadata for string
column, the value can be modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
