Jackie-Jiang commented on code in PR #16983:
URL: https://github.com/apache/pinot/pull/16983#discussion_r2421832580
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -3631,7 +3631,13 @@ public void testNonScanAggregationQueries(boolean
useMultiStageQueryEngine)
testNonScanAggregationQuery(query, h2Query);
// STRING
- // TODO: add test cases for string column when we add support for min and
max on string datatype columns
+ query = "SELECT MINSTRING(Carrier) FROM " + tableName;
Review Comment:
We can probably send the same query given the query re-write is already added
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java:
##########
@@ -49,11 +49,11 @@
@SuppressWarnings("rawtypes")
public class AggregationPlanNode implements PlanNode {
private static final EnumSet<AggregationFunctionType>
DICTIONARY_BASED_FUNCTIONS =
- EnumSet.of(MIN, MINMV, MAX, MAXMV, MINMAXRANGE, MINMAXRANGEMV,
DISTINCTCOUNT, DISTINCTCOUNTMV, DISTINCTSUM,
- DISTINCTSUMMV, DISTINCTAVG, DISTINCTAVGMV, DISTINCTCOUNTOFFHEAP,
DISTINCTCOUNTHLL, DISTINCTCOUNTHLLMV,
- DISTINCTCOUNTRAWHLL, DISTINCTCOUNTRAWHLLMV, DISTINCTCOUNTHLLPLUS,
DISTINCTCOUNTHLLPLUSMV,
- DISTINCTCOUNTRAWHLLPLUS, DISTINCTCOUNTRAWHLLPLUSMV,
DISTINCTCOUNTULL, DISTINCTCOUNTRAWULL,
- SEGMENTPARTITIONEDDISTINCTCOUNT, DISTINCTCOUNTSMARTHLL,
DISTINCTCOUNTSMARTULL);
+ EnumSet.of(MIN, MINMV, MINSTRING, MAX, MAXMV, MAXSTRING, MINMAXRANGE,
MINMAXRANGEMV, DISTINCTCOUNT,
+ DISTINCTCOUNTMV, DISTINCTSUM, DISTINCTSUMMV, DISTINCTAVG,
DISTINCTAVGMV, DISTINCTCOUNTOFFHEAP,
+ DISTINCTCOUNTHLL, DISTINCTCOUNTHLLMV, DISTINCTCOUNTRAWHLL,
DISTINCTCOUNTRAWHLLMV, DISTINCTCOUNTHLLPLUS,
+ DISTINCTCOUNTHLLPLUSMV, DISTINCTCOUNTRAWHLLPLUS,
DISTINCTCOUNTRAWHLLPLUSMV, DISTINCTCOUNTULL,
+ DISTINCTCOUNTRAWULL, SEGMENTPARTITIONEDDISTINCTCOUNT,
DISTINCTCOUNTSMARTHLL, DISTINCTCOUNTSMARTULL);
// DISTINCTCOUNT excluded because consuming segment metadata contains
unknown cardinality when there is no dictionary
Review Comment:
Consider adding some comments here on why we don't include MINSTRING and
MAXSTRING here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
