Jackie-Jiang commented on code in PR #16983:
URL: https://github.com/apache/pinot/pull/16983#discussion_r2421828156
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java:
##########
@@ -99,15 +99,23 @@ protected AggregationResultsBlock getNextBlock() {
break;
case MIN:
case MINMV:
- result = getMinValue(dataSource);
+ result = getMinValueNumeric(dataSource);
+ break;
+ case MINSTRING:
+ result = dataSource.getDictionary() != null ?
dataSource.getDictionary().getMinVal()
+ : dataSource.getDataSourceMetadata().getMinValue();
Review Comment:
> Will the segment metadata not be fixed whenever the cluster is upgraded to
a newer version containing this new aggregation function and optimization? Or
are the segment metadata properties only updated on explicit reload / refresh?
I think this particular issue won't be automatically corrected even with
reload/refresh. We probably have to re-create the segment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
