krishan1390 commented on code in PR #16845:
URL: https://github.com/apache/pinot/pull/16845#discussion_r2396437422
##########
pinot-controller/src/test/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimatorTest.java:
##########
@@ -50,7 +50,7 @@ public void testSegmentGenerator()
assertEquals(extract(metadata, "column.colFloatMV.cardinality =
(\\d+)"), "250");
assertEquals(extract(metadata, "column.colString.cardinality = (\\d+)"),
"300");
assertEquals(extract(metadata, "column.colStringMV.cardinality =
(\\d+)"), "350");
- assertEquals(extract(metadata, "column.colBytes.cardinality = (\\d+)"),
"400");
+ assertEquals(extract(metadata, "column.colBytes.cardinality = (\\d+)"),
"443");
Review Comment:
Yes there aren't any known issues with reduced cardinality.
But the 10% buffer is primarily to reduce probability of facing an unknown
issue when the feature is enabled and the approximate cardinality is lesser
than actual cardinality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
