krishan1390 commented on code in PR #16845:
URL: https://github.com/apache/pinot/pull/16845#discussion_r2403682452
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/ColumnIndexCreationInfo.java:
##########
@@ -64,11 +65,23 @@ public Object getMax() {
}
public Object getSortedUniqueElementsArray() {
- return _columnStatistics.getUniqueValuesSet();
+ try {
+ return _columnStatistics.getUniqueValuesSet();
+ } catch (NotImplementedException e) {
+ return null;
+ }
}
public int getDistinctValueCount() {
- Object uniqueValArray = _columnStatistics.getUniqueValuesSet();
+ Object uniqueValArray;
Review Comment:
yea even I wanted to do it. but not sure why it wasn't done before or was it
just a miss. A difference is _columnStatistics.getCardinality() returns some
values even if _columnStatistics isn't sealed. But
_columnStatistics.getUniqueValuesSet() throws an exception if its not sealed.
Although that shouldn't matter probably in the use cases.
doing the change now and hopefully I don't break anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
