raghavyadav01 commented on code in PR #16845:
URL: https://github.com/apache/pinot/pull/16845#discussion_r2408857632
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/stats/MapColumnPreIndexStatsCollector.java:
##########
@@ -51,16 +54,24 @@ public class MapColumnPreIndexStatsCollector extends
AbstractColumnStatisticsCol
private final Object2ObjectOpenHashMap<String,
AbstractColumnStatisticsCollector> _keyStats =
new Object2ObjectOpenHashMap<>(INITIAL_HASH_SET_SIZE);
private final Map<String, Integer> _keyFrequencies = new
Object2ObjectOpenHashMap<>(INITIAL_HASH_SET_SIZE);
- private String[] _sortedValues;
+ private String[] _sortedKeys;
private int _minLength = Integer.MAX_VALUE;
private int _maxLength = 0;
private boolean _sealed = false;
private ComplexFieldSpec _colFieldSpec;
+ private boolean _createNoDictCollectorsForKeys = false;
public MapColumnPreIndexStatsCollector(String column, StatsCollectorConfig
statsCollectorConfig) {
super(column, statsCollectorConfig);
_sorted = false;
_colFieldSpec = (ComplexFieldSpec)
statsCollectorConfig.getFieldSpecForColumn(column);
+ Map<String, FieldIndexConfigs> indexConfigsByCol =
FieldIndexConfigsUtil.createIndexConfigsByColName(
Review Comment:
We apply the same settings to all keys column within a MAP.
Here is an example, Below key Type and Value type will be same for all
key/value.
`"complexFieldSpecs": [
{
"name": "dimensions",
"dataType": "MAP",
"fieldType": "COMPLEX",
"childFieldSpecs": {
"value": {
"name": "value",
"dataType": "STRING",
"fieldType": "DIMENSION"
},
"key": {
"name": "key",
"dataType": "STRING",
"fieldType": "DIMENSION"
}
}
}
]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
