krishan1390 commented on code in PR #16845:
URL: https://github.com/apache/pinot/pull/16845#discussion_r2396404009
##########
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/data/generator/StringGenerator.java:
##########
@@ -51,8 +50,8 @@ public StringGenerator(Integer cardinality, Double
numberOfValuesPerEntry, Integ
int initValueSize = lengthOfEachString - _counterLength;
Preconditions.checkState(initValueSize >= 0,
String.format("Cannot generate %d unique string with length %d",
_cardinality, lengthOfEachString));
- _initialValue = RandomStringUtils.randomAlphabetic(initValueSize);
- _rand = new Random(System.currentTimeMillis());
+ _rand = new Random(0L);
Review Comment:
Using random strings was leading to different hll approximations. The actual
cardinality is fixed but based on the data, the approximate cardinality varies.
Hence required to fix the seed. Let me revert this and disable the table config
flag for this specific test. There are other tests to validate changes related
to approximate cardinality, so it's fine to disable it in this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
