krishan1390 commented on code in PR #16845:
URL: https://github.com/apache/pinot/pull/16845#discussion_r2375733028
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/ColumnIndexCreationInfo.java:
##########
@@ -64,11 +65,23 @@ public Object getMax() {
}
public Object getSortedUniqueElementsArray() {
- return _columnStatistics.getUniqueValuesSet();
+ try {
+ return _columnStatistics.getUniqueValuesSet();
+ } catch (NotImplementedException e) {
+ return null;
+ }
Review Comment:
that would also not be ideal as clients might miss calling that method and
then need to handle nulls if not an exception. don't see any intuitive way to
handle this. exception seems most appropriate to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
