9aman commented on code in PR #16572:
URL: https://github.com/apache/pinot/pull/16572#discussion_r2284341354


##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConsumer.java:
##########
@@ -82,6 +83,7 @@ public synchronized KafkaMessageBatch 
fetchMessages(StreamPartitionMsgOffset sta
           String key = record.key();
           byte[] keyBytes = key != null ? key.getBytes(StandardCharsets.UTF_8) 
: null;
           filteredRecords.add(new BytesStreamMessage(keyBytes, message.get(), 
messageMetadata));
+          batchSizeInBytes += messageMetadata.getRecordSerializedSize();

Review Comment:
   Noob question, is byte level rate limiting done based on serialized size of 
the message batch ?
   Does this `messageMetadata.getRecordSerializedSize();` give metadata for the 
entire message batch fetched ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to