noob-se7en commented on code in PR #16572:
URL: https://github.com/apache/pinot/pull/16572#discussion_r2272167875
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java:
##########
@@ -115,12 +124,22 @@ private void createOrUpdateServerRateLimiter(double
serverRateLimit, ServerMetri
// result of it, But the metric related to throttling won't be emitted
since as a result of here above the
// AsyncMetricEmitter will be closed. It's recommended to forceCommit
segments to avoid this.
}
+ return;
+ }
+
+ if (currentRateLimiter instanceof ServerRateLimiter) {
+ ServerRateLimiter existingLimiter = (ServerRateLimiter)
_serverRateLimiter;
+ existingLimiter.updateRateLimit(serverRateLimit, throttlingStrategy);
Review Comment:
not valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
