9aman commented on code in PR #16572:
URL: https://github.com/apache/pinot/pull/16572#discussion_r2284355117
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisMessageBatch.java:
##########
@@ -31,12 +31,14 @@ public class KinesisMessageBatch implements
MessageBatch<byte[]> {
private final List<BytesStreamMessage> _messages;
private final KinesisPartitionGroupOffset _offsetOfNextBatch;
private final boolean _endOfShard;
+ private final long _sizeInBytes;
public KinesisMessageBatch(List<BytesStreamMessage> messages,
KinesisPartitionGroupOffset offsetOfNextBatch,
- boolean endOfShard) {
+ boolean endOfShard, long batchSizeInBytes) {
_messages = messages;
_offsetOfNextBatch = offsetOfNextBatch;
_endOfShard = endOfShard;
+ _sizeInBytes = batchSizeInBytes;
Review Comment:
```suggestion
_sizeInBytes = sizeInBytes;
```
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisMessageBatch.java:
##########
@@ -31,12 +31,14 @@ public class KinesisMessageBatch implements
MessageBatch<byte[]> {
private final List<BytesStreamMessage> _messages;
private final KinesisPartitionGroupOffset _offsetOfNextBatch;
private final boolean _endOfShard;
+ private final long _sizeInBytes;
public KinesisMessageBatch(List<BytesStreamMessage> messages,
KinesisPartitionGroupOffset offsetOfNextBatch,
- boolean endOfShard) {
+ boolean endOfShard, long batchSizeInBytes) {
Review Comment:
For uniformity and correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
