gortiz commented on PR #16474: URL: https://github.com/apache/pinot/pull/16474#issuecomment-3150127034
> Versions higher than 1.4 should be backward compatible. Given we haven't released 1.4 yet, are you running into problems because the version is 1.4.0-SNAPSHOT? This is not precise. Some older 1.4.0-SNAPSHOT versions were compatible with 1.3.0 and therefore not compatible with the latest 1.4.0-SNAPSHOT. The reason why the code worked is that the old 1.4.0-SNAPSHOT versions did not store their version in helix, so the SAFE mechanism saw a null version and therefore considered that stats should not be sent. Although the older code should be correct, it was difficult to reason about it. Therefore we decided to honor the name of the predicate and be _safe_ (maybe too much) and do not send stats in cases the cluster is heterogeneous. Otherwise we would need to update the predicate in case we break some stat encoding on the same 1.x.0-SNAPSHOT. In the future we can create a SMART predicate that tries to keep stats even in heterogeneous clusters when all versions are compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
