gortiz opened a new pull request, #16474: URL: https://github.com/apache/pinot/pull/16474
In MSE, stats are sent from server to server through the mailboxes. But these stats may change between two different Pinot versions, which could produce issues when unexpected stats are deserialized. SendStatsPredicate.Safe was introduced precisely to avoid that problem by not sending MSE stats when the cluster contains two nodes using incompatible versions. The algorithm we have in master decides not to send stats when: * At least one node uses an unknown version * At least one node uses a version older than 1.4.x * At least one version uses a version higher than 2.x This may not be perfect, given we could break backward compatibility inside the same 1.4.x version. This is why the new algorithm decides not to send stats whenever the cluster is heterogeneous (defined as when there is at least one node using a different version than our own). It also adds a new log when we are in heterogeneous mode, and we receive a new update cluster, but we remain in heterogeneous mode. This is useful to log whether we are progressing or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
