gortiz commented on code in PR #16474:
URL: https://github.com/apache/pinot/pull/16474#discussion_r2245136158
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SendStatsPredicate.java:
##########
@@ -210,6 +211,8 @@ public synchronized void
onInstanceConfigChange(List<InstanceConfig> instanceCon
} else {
LOGGER.warn("Send MSE stats is now disabled (problematic versions:
{})", _problematicVersionsById);
}
+ } else if (!_sendStats) {
+ LOGGER.info("Send MSE stats is still disabled (problematic versions:
{})", _problematicVersionsById);
Review Comment:
This will also log when, for example, a minion joins the cluster if and only
if we are not sending stats.
Given `_sendStats` should almost always be true, I think it is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
