ankitsultana commented on code in PR #16242:
URL: https://github.com/apache/pinot/pull/16242#discussion_r2183864739
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/MailboxSendNode.java:
##########
@@ -52,22 +54,38 @@ private MailboxSendNode(int stageId, DataSchema dataSchema,
List<PlanNode> input
_prePartitioned = prePartitioned;
_collations = collations != null ? collations : List.of();
_sort = sort;
+ _hashFunction = hashFunction;
}
public MailboxSendNode(int stageId, DataSchema dataSchema, List<PlanNode>
inputs,
@Nullable List<Integer> receiverStages, PinotRelExchangeType
exchangeType,
RelDistribution.Type distributionType, @Nullable List<Integer> keys,
boolean prePartitioned,
@Nullable List<RelFieldCollation> collations, boolean sort) {
this(stageId, dataSchema, inputs, toBitSet(receiverStages), exchangeType,
- distributionType, keys, prePartitioned, collations, sort);
+ distributionType, keys, prePartitioned, collations, sort,
KeySelector.DEFAULT_HASH_ALGORITHM);
}
public MailboxSendNode(int stageId, DataSchema dataSchema, List<PlanNode>
inputs,
Review Comment:
This is one of the risk with having too many ctors. This one is used in
PlanFragmenter in visitExchange (which means hash function is not getting
passed).
You can pass in the hash function there by adding `node.getHashFunction()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
