ankitsultana commented on code in PR #16242:
URL: https://github.com/apache/pinot/pull/16242#discussion_r2181159106
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/PRelToPlanNodeConverter.java:
##########
@@ -117,7 +118,8 @@ public static ExchangeNode
convertPhysicalExchange(PhysicalExchange node) {
return new ExchangeNode(DEFAULT_STAGE_ID, toDataSchema(node.getRowType()),
new ArrayList<>(), node.getRelExchangeType(),
RelDistribution.Type.ANY, node.getDistributionKeys(),
false, node.getRelCollation().getFieldCollations(), false,
- !node.getRelCollation().getKeys().isEmpty(), Set.of() /* table names
*/, node.getExchangeStrategy());
+ !node.getRelCollation().getKeys().isEmpty(), Set.of() /* table names
*/, node.getExchangeStrategy(),
+ KeySelector.DEFAULT_HASH_ALGORITHM);
Review Comment:
We need to pass the hash value through for the v2 optimizer too. I can raise
a separate patch for this though since this is already a big PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
