ankitsultana commented on code in PR #16242: URL: https://github.com/apache/pinot/pull/16242#discussion_r2183888400
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/partitioning/HashFunctionSelector.java: ########## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.planner.partitioning; + +import java.nio.charset.StandardCharsets; +import org.apache.pinot.spi.utils.hash.CityHashFunctions; +import org.apache.pinot.spi.utils.hash.MurmurHashFunctions; + + +/** + * Utility class to compute hash values using different hash functions. + * This class provides consistent hash computation for KeySelector implementations. + */ +public class HashFunctionSelector { + public static final String MURMUR2 = "murmur"; + public static final String MURMUR3 = "murmur3"; Review Comment: Can you also add "hashcode" here? Also better to remove city. hash since it's not supported for table level hashes anyways -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
