shauryachats commented on code in PR #16242:
URL: https://github.com/apache/pinot/pull/16242#discussion_r2176552785
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/partitioning/MultiColumnKeySelector.java:
##########
@@ -60,11 +66,16 @@ public int computeHash(Object[] input) {
for (int keyId : _keyIds) {
Object value = input[keyId];
if (value != null) {
- hashCode += value.hashCode();
+ hashCode += HashFunctionSelector.computeHash(value, _hashFunction);
Review Comment:
Self review: The `computeHash` behaviour for default `absHashCode` would be
different than the existing one, which should be okay since the value returned
by the `computeHash` would still be positive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
