vrajat commented on PR #16040:
URL: https://github.com/apache/pinot/pull/16040#issuecomment-2979263651
I am going to snooze this PR for now. The issue is that a global singleton
`ThreadResourceUsageAccountant` requires separate query ids on the broker and
server for an integration test to work.
Quick deep dive:
From one of the tests in the file, the query resources for a SSE query are:
```
Broker_localhost_21001_2087751584000000002_O=AggregatedStats{_queryId='Broker_localhost_21001_2087751584000000002_O',
_anchorThread=Thread[#389,pqr-1,7,main], _isAnchorThread=true,
_exceptionAtomicReference=java.lang.RuntimeException: Query
Broker_localhost_21001_2087751584000000002_O got killed because using 813788824
bytes of memory on SERVER: Server_localhost_22004, exceeding the quota,
_allocatedBytes=813788824, _cpuNS=0},
2087751584000000002=AggregatedStats{_queryId='2087751584000000002',
_anchorThread=Thread[#388,jersey-server-managed-async-executor-2,5,main],
_isAnchorThread=true, _exceptionAtomicReference=null, _allocatedBytes=0,
_cpuNS=0}} for the previous kill.
```
Lets break this down:
There are two entries in the map:
* `Broker_localhost_21001_2087751584000000002_O`
* `2087751584000000002`
This is because this feature uses different query ids for the same query in
broker and server.
If the query id is normalized across the broker and server, then there will
be one entry. The same entry will have two runners - one from the broker and
server in the global singleton map. This confuses the accountant infra. So a
precursor is to solve #15231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
