vrajat commented on code in PR #16040:
URL: https://github.com/apache/pinot/pull/16040#discussion_r2145005239
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -317,7 +317,7 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
_queryLogger.log(requestId, query);
//Start instrumentation context. This must not be moved further below
interspersed into the code.
- Tracing.ThreadAccountantOps.setupRunner(String.valueOf(requestId));
+ Tracing.ThreadAccountantOps.setupRunner(QueryThreadContext.getCid());
Review Comment:
Agree. The issue is that the backward-incompatible check will fail.
I'll keep this in mind in a WIP PR where I plan to blow up the whole file
with lots of backward-incompatible changes including removal of the singleton.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
