Copilot commented on code in PR #16040:
URL: https://github.com/apache/pinot/pull/16040#discussion_r2139908174
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/logicaltable/LogicalTableWithOneOfflineOneRealtimeTableIntegrationTest.java:
##########
@@ -41,4 +43,25 @@ protected Map<String, List<File>>
getRealtimeTableDataFiles() {
return distributeFilesToTables(getRealtimeTableNames(),
_avroFiles.subList(_avroFiles.size() - 4, _avroFiles.size()));
}
+
+ protected void overrideServerConf(PinotConfiguration serverConf) {
+ serverConf.setProperty(
+ CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX + "." +
CommonConstants.Accounting.CONFIG_OF_FACTORY_NAME,
+ "org.apache.pinot.core.accounting.PerQueryCPUMemAccountantFactory");
Review Comment:
[nitpick] Hardcoding the factory class name as a string can be brittle;
consider using `PerQueryCPUMemAccountantFactory.class.getName()` to improve
refactoring safety.
```suggestion
PerQueryCPUMemAccountantFactory.class.getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
