noob-se7en commented on code in PR #16045:
URL: https://github.com/apache/pinot/pull/16045#discussion_r2146285125
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableInstances.java:
##########
@@ -186,4 +198,66 @@ public Map<String, List<InstanceInfo>>
getLiveBrokers(@Context HttpHeaders heade
throw new ControllerApplicationException(LOGGER, e.getMessage(),
Response.Status.NOT_FOUND);
}
}
+
+ @DELETE
+ @Path("/table/{tableNameWithType}/{instanceName}/ingestionMetrics")
+ @Produces(MediaType.APPLICATION_JSON)
+ @Authorize(targetType = TargetType.TABLE, paramName = "tableNameWithType",
action =
+ Actions.Table.DELETE_INGESTION_METRICS)
+ @Authenticate(AccessType.DELETE)
+ @ApiOperation(value = "Remove realtime ingestion metrics emitted per
partitionGroupID from serverInstance",
+ notes = "Removes ingestion-related metrics from serverInstance for
partition(s) under the specified table")
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Successfully removed ingestion
metrics."),
+ @ApiResponse(code = 500, message = "Internal Server Error")
+ })
+ public SuccessResponse removeIngestionMetrics(
+ @ApiParam(value = "Table name with type", required = true)
@PathParam("tableNameWithType")
+ String tableNameWithType,
+ @ApiParam(value = "Instance name of the server", required = true)
@PathParam("instanceName")
+ String instanceName,
+ @ApiParam(value = "Comma-separated list of partition group IDs
(optional)") @QueryParam("partitionGroupId")
Review Comment:
Corrected.
It takes a list (shown in screenshot in PR description)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]