Jackie-Jiang commented on code in PR #16045:
URL: https://github.com/apache/pinot/pull/16045#discussion_r2143581069
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1257,6 +1261,59 @@ public SuccessResponse deleteSegmentsFromSequenceNum(
return new SuccessResponse("Successfully deleted segments for table: " +
tableNameWithType);
}
+ @DELETE
+ @Path("/segments/{tableNameWithType}/{segmentName}/ingestion-metrics")
Review Comment:
To manually remove the ingestion metrics on a server, we should take table
name, instance id, and partition id. We can consider changing partition id to
an optional list, and remove all partitions if not provided.
In most cases, the segment is no longer served on this server, so we will
want to always ask for instance id
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1257,6 +1261,59 @@ public SuccessResponse deleteSegmentsFromSequenceNum(
return new SuccessResponse("Successfully deleted segments for table: " +
tableNameWithType);
}
+ @DELETE
+ @Path("/segments/{tableNameWithType}/{segmentName}/ingestion-metrics")
Review Comment:
We don't usually use `-` within the URL. Consider making it camel case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
