noob-se7en commented on code in PR #16045:
URL: https://github.com/apache/pinot/pull/16045#discussion_r2143619970
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1257,6 +1261,59 @@ public SuccessResponse deleteSegmentsFromSequenceNum(
return new SuccessResponse("Successfully deleted segments for table: " +
tableNameWithType);
}
+ @DELETE
+ @Path("/segments/{tableNameWithType}/{segmentName}/ingestion-metrics")
Review Comment:
In case of stream-partitions merge/decrease and metrics not removed, we
would always want to delete metrics of that partition from all instances.
That's why kept instances as optional.
Regarding having segmentName in input param, yeah my bad thats quite useless
since ingestion-metrics exposes partitionId only. I guess we should modify
`IngestionMetricsRemoveMessage` to take partitionGroupId as a param then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
