gortiz commented on code in PR #16038:
URL: https://github.com/apache/pinot/pull/16038#discussion_r2144646493
##########
pinot-query-runtime/src/test/resources/queries/LeftAntiJoins.json:
##########
@@ -0,0 +1,65 @@
+{
+ "left_join_null_filter_test": {
+ "tables": {
+ "t1": {
+ "schema": [
+ {"name": "key_col", "type": "STRING"},
+ {"name": "event_time", "type": "INT"}
+ ],
+ "inputs": [
+ ["a", 1],
+ ["b", 2],
+ ["c", 3],
+ ["d", 4],
+ ["e", 5]
+ ]
+ },
+ "t2": {
+ "schema": [
+ {"name": "key_col", "type": "STRING"},
+ {"name": "event_time", "type": "INT"}
+ ],
+ "inputs": [
+ ["b", 2],
+ ["a", 1],
+ ["c", 3],
+ ["a", 2],
+ ["c", 1],
+ ["b", 3],
+ ["d", 5]
+ ]
+ }
+ },
+ "queries": [
+ {
+ "sql": "SELECT {t1}.key_col, {t1}.event_time FROM {t1} LEFT JOIN {t2}
ON {t1}.key_col = {t2}.key_col AND {t1}.event_time > {t2}.event_time WHERE
{t2}.key_col IS NULL",
+ "outputs": [
+ ["a", 1],
+ ["b", 2],
+ ["d", 4],
+ ["e", 5]
+ ]
Review Comment:
You can also delegate on H2, which is probably going to be better given we
don't have a clear picture of the actual semantics. As @yashmayya said, it
seems that Postgres follows different semantics than the ones we have in master
but also the ones you implemented here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
