soupam05 commented on PR #16038: URL: https://github.com/apache/pinot/pull/16038#issuecomment-2969394126
> Thanks for the changes. I like this solution. It is significantly simpler than the original one. > > One thing I miss is resource tests like pinot-query-runtime/src/test/resources/queries/Aggregates.json. These tests compare executions with an embedded h2 database. Do you feel you can add a new json for joins? I think that would make it easier to understand whether the ANTI join is correctly implemented or not. Thanks! I'm glad the simplification works well. You're absolutely right — adding a resource-based test for joins would definitely improve clarity and confidence, especially for validating correctness against H2. I'll go ahead and add a new JSON test file (e.g., Joins.json) under pinot-query-runtime/src/test/resources/queries/. It’ll cover typical join scenarios, with a focus on validating LEFT ANTI JOIN behavior using H2 semantics (e.g., LEFT JOIN ... WHERE right.key IS NULL). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
