gortiz commented on code in PR #16038:
URL: https://github.com/apache/pinot/pull/16038#discussion_r2144635377
##########
pinot-query-runtime/src/test/resources/queries/LeftAntiJoins.json:
##########
@@ -0,0 +1,65 @@
+{
+ "left_join_null_filter_test": {
+ "tables": {
+ "t1": {
+ "schema": [
+ {"name": "key_col", "type": "STRING"},
+ {"name": "event_time", "type": "INT"}
+ ],
+ "inputs": [
+ ["a", 1],
+ ["b", 2],
+ ["c", 3],
+ ["d", 4],
+ ["e", 5]
+ ]
+ },
+ "t2": {
+ "schema": [
+ {"name": "key_col", "type": "STRING"},
+ {"name": "event_time", "type": "INT"}
+ ],
+ "inputs": [
+ ["b", 2],
+ ["a", 1],
+ ["c", 3],
+ ["a", 2],
+ ["c", 1],
+ ["b", 3],
+ ["d", 5]
+ ]
+ }
+ },
Review Comment:
There are no nulls on these tables, right? So we are not testing how IS NULL
behaves. You also need to apply some changes on the schema and query, as you
can see in `NullHandling.json`:
You need to include ` "notNull": false` in the schema and probably also
include `SET enableNullHandling=true;`
##########
pinot-query-runtime/src/test/resources/queries/LeftAntiJoins.json:
##########
@@ -0,0 +1,65 @@
+{
+ "left_join_null_filter_test": {
+ "tables": {
+ "t1": {
+ "schema": [
+ {"name": "key_col", "type": "STRING"},
+ {"name": "event_time", "type": "INT"}
+ ],
+ "inputs": [
+ ["a", 1],
+ ["b", 2],
+ ["c", 3],
+ ["d", 4],
+ ["e", 5]
+ ]
+ },
+ "t2": {
+ "schema": [
+ {"name": "key_col", "type": "STRING"},
+ {"name": "event_time", "type": "INT"}
+ ],
+ "inputs": [
+ ["b", 2],
+ ["a", 1],
+ ["c", 3],
+ ["a", 2],
+ ["c", 1],
+ ["b", 3],
+ ["d", 5]
+ ]
+ }
+ },
Review Comment:
There are no nulls on these tables, right? So we are not testing how IS NULL
behaves. You also need to apply some changes to the schema and query, as you
can see in `NullHandling.json`:
You need to include ` "notNull": false` in the schema and probably also
include `SET enableNullHandling=true;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
