somandal commented on code in PR #15973:
URL: https://github.com/apache/pinot/pull/15973#discussion_r2133178036
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentStarTreePreprocessThrottler.java:
##########
@@ -62,4 +61,14 @@ public synchronized void onChange(Set<String>
changedConfigs, Map<String, String
CommonConstants.Helix.DEFAULT_MAX_SEGMENT_STARTREE_PREPROCESS_PARALLELISM_BEFORE_SERVING_QUERIES);
LOGGER.info("Updated SegmentStarTreePreprocessThrottler configs with
latest clusterConfigs");
}
+
+ @Override
+ public void updateThresholdMetric(int value) {
+
_serverMetrics.setValueOfGlobalGauge(ServerGauge.SEGMENT_STARTREE_PREPROCESS_THROTTLE_THRESHOLD,
value);
Review Comment:
Same here, this is for startree index reload throttling (also this metric
already exists, it just moved to this method instead of passing it in the
constructor)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
