deepthi912 commented on code in PR #15973:
URL: https://github.com/apache/pinot/pull/15973#discussion_r2133102066
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -644,38 +644,17 @@ public void start()
ServerSegmentCompletionProtocolHandler.init(
_serverConf.subset(SegmentCompletionProtocol.PREFIX_OF_CONFIG_OF_SEGMENT_UPLOADER));
- int maxPreprocessConcurrency = Integer.parseInt(
-
_serverConf.getProperty(Helix.CONFIG_OF_MAX_SEGMENT_PREPROCESS_PARALLELISM,
- Helix.DEFAULT_MAX_SEGMENT_PREPROCESS_PARALLELISM));
- int maxPreprocessConcurrencyBeforeServingQueries = Integer.parseInt(
-
_serverConf.getProperty(Helix.CONFIG_OF_MAX_SEGMENT_PREPROCESS_PARALLELISM_BEFORE_SERVING_QUERIES,
-
Helix.DEFAULT_MAX_SEGMENT_PREPROCESS_PARALLELISM_BEFORE_SERVING_QUERIES));
- // Relax throttling until the server is ready to serve queries
- SegmentAllIndexPreprocessThrottler segmentAllIndexPreprocessThrottler =
- new SegmentAllIndexPreprocessThrottler(maxPreprocessConcurrency,
maxPreprocessConcurrencyBeforeServingQueries,
- false);
- int maxStarTreePreprocessConcurrency = Integer.parseInt(
-
_serverConf.getProperty(Helix.CONFIG_OF_MAX_SEGMENT_STARTREE_PREPROCESS_PARALLELISM,
- Helix.DEFAULT_MAX_SEGMENT_STARTREE_PREPROCESS_PARALLELISM));
- int maxStarTreePreprocessConcurrencyBeforeServingQueries =
Integer.parseInt(
-
_serverConf.getProperty(Helix.CONFIG_OF_MAX_SEGMENT_STARTREE_PREPROCESS_PARALLELISM_BEFORE_SERVING_QUERIES,
-
Helix.DEFAULT_MAX_SEGMENT_STARTREE_PREPROCESS_PARALLELISM_BEFORE_SERVING_QUERIES));
- // Relax throttling until the server is ready to serve queries
- SegmentStarTreePreprocessThrottler segmentStarTreePreprocessThrottler =
- new
SegmentStarTreePreprocessThrottler(maxStarTreePreprocessConcurrency,
- maxStarTreePreprocessConcurrencyBeforeServingQueries, false);
- int maxDownloadConcurrency = Integer.parseInt(
-
_serverConf.getProperty(Helix.CONFIG_OF_MAX_SEGMENT_DOWNLOAD_PARALLELISM,
- Helix.DEFAULT_MAX_SEGMENT_DOWNLOAD_PARALLELISM));
- int maxDownloadConcurrencyBeforeServingQueries = Integer.parseInt(
-
_serverConf.getProperty(Helix.CONFIG_OF_MAX_SEGMENT_DOWNLOAD_PARALLELISM_BEFORE_SERVING_QUERIES,
-
Helix.DEFAULT_MAX_SEGMENT_DOWNLOAD_PARALLELISM_BEFORE_SERVING_QUERIES));
- // Relax throttling until the server is ready to serve queries
- SegmentDownloadThrottler segmentDownloadThrottler =
- new SegmentDownloadThrottler(maxDownloadConcurrency,
maxDownloadConcurrencyBeforeServingQueries, false);
- _segmentOperationsThrottler =
- new SegmentOperationsThrottler(segmentAllIndexPreprocessThrottler,
segmentStarTreePreprocessThrottler,
- segmentDownloadThrottler);
+ if (_segmentOperationsThrottler == null) {
+ // Only create segment operation throttlers if null
+ SegmentAllIndexPreprocessThrottler segmentAllIndexPreprocessThrottler =
+ createSegmentAllIndexPreprocessThrottler();
+ SegmentStarTreePreprocessThrottler segmentStarTreePreprocessThrottler =
+ createSegmentStarTreePreprocessThrottler();
Review Comment:
Why do we have `SegmentStarTreePreprocessThrottler` customized class name
like this? Shouldn't this be more of a class name dependent on functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
