Jackie-Jiang commented on code in PR #15973:
URL: https://github.com/apache/pinot/pull/15973#discussion_r2129880096
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManager.java:
##########
@@ -41,7 +43,8 @@ public interface TableUpsertMetadataManager extends Closeable
{
void init(PinotConfiguration instanceUpsertConfig, TableConfig tableConfig,
Schema schema,
TableDataManager tableDataManager);
- PartitionUpsertMetadataManager getOrCreatePartitionManager(int partitionId);
+ PartitionUpsertMetadataManager getOrCreatePartitionManager(int partitionId,
Review Comment:
Given `segmentOperationsThrottler` is instance level class, can we pass it
in through `init()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
