tarun11Mavani commented on issue #15846: URL: https://github.com/apache/pinot/issues/15846#issuecomment-2950013483
> Looking into the idea proposed in [the PR](https://github.com/apache/pinot/pull/16006), instead of using an explicit Map, I think we may try to check and fix the creation.meta file during segment commit process (for the slower replicas). Like where crc is checked, we can double check creation time there too. Then the slower replicas can init the SegmentMetadata object to have the right creation time, before finish the commit process with segment it's built locally. (Feel free to tag me in the PR to continue the discussions there) thanks @klsince for the suggestion. Are you suggesting to add a check in [replaceSegmentIfCrcMismatch](https://github.com/apache/pinot/blob/9353f158b6f59dbc8d19c626f173f8b99f34b1ce/pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java#L420) to check if the creation time matches inside hasSameCRC? If the creation time don't match, fix the creation time file stored locally and continue with segment built locally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
