ankitsultana commented on issue #15846: URL: https://github.com/apache/pinot/issues/15846#issuecomment-2923003932
Had a discussion with @tarun11Mavani offline. As @Jackie-Jiang also called out, I think we should be relying on the segment zk metadata defined creation time. Since the creation_meta value is controlled independently by servers, using it to define a total order among segments is an anti-pattern and will always lead to a lot of edge cases which can be hard to manage. As part of this we should also consider fixing `shouldReplaceOnComparisonTie`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
