rohityadav1993 commented on issue #15846: URL: https://github.com/apache/pinot/issues/15846#issuecomment-2948304591
@klsince > the seqId field is encoded in LLCSegment and UploadedSegment names so we can save those ZK accesses [UploadedRealtimeSegmentName](https://github.com/apache/pinot/blob/2760c07d7f139e1e1fd59865fe4cb5b3bf0d2743/pinot-common/src/main/java/org/apache/pinot/common/utils/UploadedRealtimeSegmentName.java#L44) does not explicitly has seqId. We should avoid building any logic on comparing seqId between UploadedRealtimeSegment or RealtimeSegment. For uploaded segments one issue is creation.meta differs between replicas which we can resolve with ZK time. For second issue caused due to preferring existing segment over replacing segment can be modified to prefer replacing segment only when UploadedSegment characteristics are same(comparisonColumn, creation time). Reason to avoid giving priority to replacing segment for LLCSegment is, these segments are generated by Pinot and same segment implies same data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
