abhishekbafna commented on code in PR #15881: URL: https://github.com/apache/pinot/pull/15881#discussion_r2126437055
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ########## @@ -1702,4 +1702,14 @@ public static class Groovy { public static final String GROOVY_QUERY_STATIC_ANALYZER_CONFIG = "pinot.groovy.query.static.analyzer"; public static final String GROOVY_INGESTION_STATIC_ANALYZER_CONFIG = "pinot.groovy.ingestion.static.analyzer"; } + + /** + * ZK paths used by Pinot. + */ + public static class ZkPaths { + public static final String LOGICAL_TABLE_PARENT_PATH = "/LOGICAL/TABLE"; + public static final String LOGICAL_TABLE_PATH_PREFIX = "/LOGICAL/TABLE/"; + public static final String TABLE_CONFIG_PATH_PREFIX = "/CONFIGS/TABLE/"; + public static final String SCHEMA_PATH_PREFIX = "/SCHEMAS/"; Review Comment: The `ZKMetadataProvider` constants are private. Also the existing pattern was to duplicate them. In this we are defining them at a central place and that should be used going forward instead of defining them again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org