gortiz commented on PR #15878: URL: https://github.com/apache/pinot/pull/15878#issuecomment-2922501111
Nice catch, but I'm not sure if I correctly understood your case. `pinot.offheap.prioritize.bytebuffer` defaults to true. Are you changing it to false? Or were you using false and now you are trying to set it to true? I assume the issue was found when UnsafePinotBuffers were used, right? PS: Can you add the benchmark as well? We usually store them in pinot-perf/src/main/java/org/apache/pinot/perf/. For example we have one comparing performance of different buffer implementations in pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkPinotDataBuffer.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
