abhishekbafna commented on code in PR #15881: URL: https://github.com/apache/pinot/pull/15881#discussion_r2107377011
########## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ########## @@ -242,6 +273,7 @@ public synchronized void shutDown() { } } SegmentBuildTimeLeaseExtender.shutdownExecutor(); + _propertyStore.unsubscribeChildChanges(LOGICAL_TABLE_PARENT_PATH, _zkLogicalTableConfigChangeListener); Review Comment: This is child change listener which notifies as when a child is added/updated. We have this listener for logical table only. `IZkChildListener` is implemented for logical table only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org