ankitsultana commented on code in PR #15780:
URL: https://github.com/apache/pinot/pull/15780#discussion_r2114805525
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpartition/SegmentPartitionMetadataManager.java:
##########
@@ -136,7 +138,68 @@ private static List<String> getOnlineServers(ExternalView
externalView, String s
return onlineServers;
}
- private void computeTablePartitionInfo() {
+ @Override
+ public synchronized void onAssignmentChange(IdealState idealState,
ExternalView externalView,
Review Comment:
note: GH is not great at showing this but I have simply moved the compute
table partition info methods towards the end. however reviewers can double
check this claim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
