ankitsultana commented on PR #15780: URL: https://github.com/apache/pinot/pull/15780#issuecomment-2892609614
Isn't that an overkill? Requirements of `LeafStageWorkerAssignmentRule` and `WorkerManager` are different, but from an abstraction point of view we can say that `SegmentPartitionMetadataManager` manages `TablePartitionInfo` which: * Provides an easy to use API to work with segment partitions. * Is a complete view, in that all processed segments will be part of the `TablePartitionInfo` POJO. Maybe I am missing something, is there a deeper reason to create another POJO here? Maintaining two separate POJOs with mostly the same information will be an anti-pattern in my view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
