ankitsultana commented on PR #15780: URL: https://github.com/apache/pinot/pull/15780#issuecomment-2918232288
On second thought, the current changes in this PR are *not* semantically correct. Like Jackie mentioned, I am only interested in getting the segments corresponding to a given partition from Segment Partition Metadata Manager. The segment selection, and exclusion of new segments, is delegated to Routing Manager, as it ideally should be. Given that, me adding excludedNewSegments to the existing POJO isn't ideal since that will allow the exclusion logic to be owned by both SegmentPartitionMetadataManager and Routing Manager. I'll update this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
