klsince commented on code in PR #15761:
URL: https://github.com/apache/pinot/pull/15761#discussion_r2085193152
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -819,6 +819,12 @@ static void validateTTLForUpsertConfig(TableConfig
tableConfig, Schema schema) {
Preconditions.checkState(comparisonColumnDataType.isNumeric(),
"MetadataTTL / DeletedKeysTTL must have comparison column: %s in
numeric type, found: %s", comparisonColumn,
comparisonColumnDataType);
+ } else {
+ String comparisonColumn =
tableConfig.getValidationConfig().getTimeColumnName();
+ DataType comparisonColumnDataType =
schema.getFieldSpecFor(comparisonColumn).getDataType();
+ Preconditions.checkState(comparisonColumnDataType.isNumeric(),
Review Comment:
as reminded by the changes to the tests below, better add a test to validate
that this fails upon non-numeric time column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
