deepthi912 commented on code in PR #15761:
URL: https://github.com/apache/pinot/pull/15761#discussion_r2085149185
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes.java:
##########
@@ -293,6 +293,9 @@ public void doRemoveExpiredPrimaryKeys() {
double largestSeenComparisonValue = _largestSeenComparisonValue.get();
double deletedKeysThreshold =
_deletedKeysTTL > 0 ? largestSeenComparisonValue - _deletedKeysTTL :
Double.NEGATIVE_INFINITY;
+ if (_deletedKeysTTL <= 0) {
Review Comment:
https://github.com/apache/pinot/blob/0f9780a0fa3036253ec5ea4d603a59575bd388c0/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java#L972
Also above check is enabled, so removed the check in as well
ConcurrentMapPartitionUpsertMetadataManager.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
