Re: [PR] Check for timeColumn type when metadataTTL or deletedKeysTTL is set for Upsert Tables [pinot]

[via GitHub]

deepthi912 commented on code in PR #15761:
URL: https://github.com/apache/pinot/pull/15761#discussion_r2085130667


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -819,6 +819,14 @@ static void validateTTLForUpsertConfig(TableConfig 
tableConfig, Schema schema) {
       Preconditions.checkState(comparisonColumnDataType.isNumeric(),
           "MetadataTTL / DeletedKeysTTL must have comparison column: %s in 
numeric type, found: %s", comparisonColumn,
           comparisonColumnDataType);
+    } else {
+      String comparisonColumn = 
tableConfig.getValidationConfig().getTimeColumnName();
+      if (comparisonColumn != null && !comparisonColumn.isEmpty()) {

Review Comment:
   It wasn't done for the timeColumn, it was failing it at ingestion stage:
   
   
![image](https://github.com/user-attachments/assets/798be299-dd31-49d5-83a9-0bec00805af1)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org